Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): Use Custom Page content type for /starfatorg #14650

Merged
merged 2 commits into from
Apr 30, 2024
Merged

feat(web): Use Custom Page content type for /starfatorg #14650

merged 2 commits into from
Apr 30, 2024

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Apr 30, 2024 •
edited by coderabbitai bot
Loading

Use Custom Page content type for /starfatorg

What

  • Since /starfatorg is a custom page we'd like it to use the Custom Page content type for displaying an alert banner among other features that the custom page content type will support in the future

Why

  • As of right now the page only uses a UI configuration for all settings that is fetched using a magic string, this change helps us standardize custom pages for the web.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced vacancy listing and details pages for Icelandic Government Institutions with improved layout management.
    • Introduced a new category 'Vacancies' in the system to better categorize custom pages.

  • Refactor

    • Improved page wrapping for consistent user interface across the vacancy-related pages.

  • Bug Fixes

    • Removed erroneous 404 error display for non-existent vacancies, ensuring accurate availability status.

@RunarVestmann RunarVestmann added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Apr 30, 2024
@RunarVestmann RunarVestmann requested review from a team as code owners April 30, 2024 14:54
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 30, 2024 •
edited
Loading

Walkthrough

The changes involve updating components related to the Icelandic government institution vacancies by integrating CustomPageUniqueIdentifier and enhancing component wrapping with withCustomPageWrapper. Additionally, the system's handling of unique identifiers for custom pages has been expanded to include a new 'Vacancies' option, aligning the front-end and CMS schema to accommodate this update.

Changes

File Path Change Summary
.../IcelandicGovernmentInstitutionVacanciesList.tsx
.../IcelandicGovernmentInstitutionVacancyDetails.tsx		 - Added import for CustomPageUniqueIdentifier.
- Introduced withCustomPageWrapper.
libs/cms/src/lib/dto/getCustomPage.input.ts
libs/cms/src/lib/generated/contentfulTypes.d.ts		 - Added Vacancies to CustomPageUniqueIdentifier enum and updated uniqueIdentifier field in ICustomPageFields.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.10%. Comparing base (9e30183) to head (63e2381).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14650      +/-   ##
==========================================
+ Coverage   37.09%   37.10%   +0.01%     
==========================================
  Files        6240     6240              
  Lines      126391   126423      +32     
  Branches    36158    36171      +13     
==========================================
+ Hits        46881    46913      +32     
  Misses      79510    79510
Flag Coverage Δ
api 3.47% <ø> (ø)
api-domains-communications 40.31% <100.00%> (+<0.01%) ⬆️
application-system-api 42.14% <100.00%> (+<0.01%) ⬆️
application-template-api-modules 24.65% <ø> (+0.04%) ⬆️
application-templates-parental-leave 25.45% <ø> (ø)
application-ui-shell 21.72% <ø> (ø)
cms 0.45% <0.00%> (-0.01%) ⬇️
cms-translations 39.38% <100.00%> (+<0.01%) ⬆️
judicial-system-api 16.97% <ø> (ø)
judicial-system-formatters 83.15% <ø> (ø)
judicial-system-web 28.63% <ø> (ø)
services-user-notification 47.41% <100.00%> (+0.04%) ⬆️
web 1.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/IcelandicGovernmentInstitutionVacanciesList.tsx 0.00% <ø> (ø)
...s/IcelandicGovernmentInstitutionVacancyDetails.tsx 0.00% <ø> (ø)
libs/cms/src/lib/dto/getCustomPage.input.ts 85.71% <100.00%> (+1.09%) ⬆️

... and 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e30183...63e2381. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs e6b110f 🔗

✅ 10 Total Test Services: 0 Failed, 9 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.01%), 23 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Code Coverage Change Test Service View
api 0 0 0 4 0 25.83ms 1 no change Link
api-domains-communications 0 0 0 5 0 141.75ms 1 no change Link
api-domains-license-service 0 0 0 0 0 0s 1 no change Link
application-system-api 0 0 0 111 2 1m 17.7s 1 no change Link
application-template-api-modules 0 0 0 107 0 48.57s 1 no change Link
cms-translations 0 0 0 3 0 24.06ms 1 increased (+0.01%) Link
judicial-system-api 0 0 0 52 0 190.86ms 1 no change Link
judicial-system-backend 0 0 0 13146 0 15m 28.8s 1 no change Link
services-user-notification 0 0 0 41 0 35.46s 1 no change Link
web 0 0 0 84 0 3.76s 1 no change Link

@kodiakhq kodiakhq bot merged commit 78660fe into main Apr 30, 2024
61 checks passed
@kodiakhq kodiakhq bot deleted the feature/web-vacancies-custom-page branch April 30, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@mannipje mannipje mannipje approved these changes

Assignees
No one assigned
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunarVestmann @mannipje